Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SSZ #28

Closed
dangerousfood opened this issue Nov 20, 2018 · 9 comments
Closed

Implement SSZ #28

dangerousfood opened this issue Nov 20, 2018 · 9 comments
Assignees
Labels
enhancement 🕵️‍♀️ New feature or request

Comments

@dangerousfood
Copy link
Contributor

Implement SSZ in accordance with the spec listed here. Additional resources can be found here here

@dangerousfood dangerousfood self-assigned this Nov 20, 2018
@dangerousfood dangerousfood added the enhancement 🕵️‍♀️ New feature or request label Nov 20, 2018
@jrhea jrhea added enhancement 🕵️‍♀️ New feature or request in progress 🚧 This issue or pull request is in progress labels Dec 24, 2018
@jrhea
Copy link
Contributor

jrhea commented Dec 24, 2018

@dangerousfood What is the status of this? Do you have an implementation in Java, or are you going to use Antoine's version in Cava?

@atoulme
Copy link
Contributor

atoulme commented Jan 12, 2019

tagging myself @atoulme so I get notified of updates.

@jrhea
Copy link
Contributor

jrhea commented Jan 12, 2019

@atoulme you finished the implementation in cava, right?

@atoulme
Copy link
Contributor

atoulme commented Jan 13, 2019

I would have to look again. The spec changed a bit since. I was unsure if we needed a special construct to handle containers. There were changes related to endianness. I also had left out the hashing.

@schroedingerscode schroedingerscode removed the in progress 🚧 This issue or pull request is in progress label Jan 13, 2019
@jrhea
Copy link
Contributor

jrhea commented Jan 15, 2019

Just glanced at the cava source and it looks like one potential issue with using the cava SSZ implementation is:

import net.consensys.cava.bytes.Bytes;
import net.consensys.cava.units.bigints.UInt256;

We have different types in Artemis.

@atoulme
Copy link
Contributor

atoulme commented Jan 17, 2019

What types do you folks need? Bytes is just an array of bytes with better methods.

FWIW Harmony is using Cava SSZ: https://github.com/harmony-dev/beacon-chain-java/blob/master/ssz/src/main/java/net/consensys/cava/ssz/BytesSSZReaderProxy.java

@atoulme
Copy link
Contributor

atoulme commented Jan 19, 2019

This PR should help: #207

@atoulme
Copy link
Contributor

atoulme commented Jan 21, 2019

PR #208 brings SSZ to the project.

@jrhea
Copy link
Contributor

jrhea commented Jan 21, 2019

resolved by #208

@jrhea jrhea closed this as completed Jan 21, 2019
zilm13 added a commit to zilm13/teku that referenced this issue May 1, 2024
* Fix el methods for EIP7594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants