First commit. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strongly recommend splitting this into two or more separate PRs. At a minimum, keep the infrastructure stuff (gradle, docker, etc.) separate from the project code (Java). Probably best to separate Docker and Gradle PRs too unless they are too closely linked. Lots of small, independent PRs are much easier to handle than monolithic PRs covering multiple things. This is also a recommended read 😉 https://chris.beams.io/posts/git-commit/ |
dangerousfood
added a commit
that referenced
this pull request
Jun 21, 2019
* Implement Test Suites to Run Shuffling Reference Tests from Eth2 Testing Spec (#715) * Update BLS tests to use official eth2 spec vectors. * Test shuffling with different validator set sizes from eth2-test spec reference tests. * Test shuffling with default shuffling test vectors from eth2-test spec reference tests. * Fix get shuffling * changes made to give p2pNetwork access to the data needed for RPC calls (#726) * V0.7.1 integration (#1) * Constants update (v0.7.1) (#725) * Change mainnet constants * Change minimal constants in config.toml * Update data structures (#727) * add bls_domain * get_churn_limit added * is_slashable_attestation_data added * validate_indexed_attestation added * get_domain modified * convert_to_indexed * get_attesting_indices modified * get_shuffled_index added * compute_committee added * get_crosslink_committee added * get_epoch_start_shard added * get_shard_delta added * get_epoch_committee_count added * get_block_root_at_slot added * get_attestation_data_slot added * decrease_balance added * increase_balance added * is_slashable_validator added * get_previous_epoch modified * get_active_validator_indices modified * get_randao_mix modified * get_active_index_root modified * generate_seed modified * get_beacon_proposer_index modified * removed methods * replacce assert * bug fixes * bug fixes * couture * bug fixes * best dev evar * bug fixes * oops
schroedingerscode
pushed a commit
to schroedingerscode/artemis
that referenced
this pull request
Jun 27, 2019
* Implement Test Suites to Run Shuffling Reference Tests from Eth2 Testing Spec (Consensys#715) * Update BLS tests to use official eth2 spec vectors. * Test shuffling with different validator set sizes from eth2-test spec reference tests. * Test shuffling with default shuffling test vectors from eth2-test spec reference tests. * Fix get shuffling * changes made to give p2pNetwork access to the data needed for RPC calls (Consensys#726) * V0.7.1 integration (Consensys#1) * Constants update (v0.7.1) (Consensys#725) * Change mainnet constants * Change minimal constants in config.toml * Update data structures (Consensys#727) * add bls_domain * get_churn_limit added * is_slashable_attestation_data added * validate_indexed_attestation added * get_domain modified * convert_to_indexed * get_attesting_indices modified * get_shuffled_index added * compute_committee added * get_crosslink_committee added * get_epoch_start_shard added * get_shard_delta added * get_epoch_committee_count added * get_block_root_at_slot added * get_attestation_data_slot added * decrease_balance added * increase_balance added * is_slashable_validator added * get_previous_epoch modified * get_active_validator_indices modified * get_randao_mix modified * get_active_index_root modified * generate_seed modified * get_beacon_proposer_index modified * removed methods * replacce assert * bug fixes * bug fixes * couture * bug fixes * best dev evar * bug fixes * oops
cemozerr
pushed a commit
that referenced
this pull request
Jun 28, 2019
* Implement Test Suites to Run Shuffling Reference Tests from Eth2 Testing Spec (#715) * Update BLS tests to use official eth2 spec vectors. * Test shuffling with different validator set sizes from eth2-test spec reference tests. * Test shuffling with default shuffling test vectors from eth2-test spec reference tests. * Fix get shuffling * changes made to give p2pNetwork access to the data needed for RPC calls (#726) * V0.7.1 integration (#1) * Constants update (v0.7.1) (#725) * Change mainnet constants * Change minimal constants in config.toml * Update data structures (#727) * add bls_domain * get_churn_limit added * is_slashable_attestation_data added * validate_indexed_attestation added * get_domain modified * convert_to_indexed * get_attesting_indices modified * get_shuffled_index added * compute_committee added * get_crosslink_committee added * get_epoch_start_shard added * get_shard_delta added * get_epoch_committee_count added * get_block_root_at_slot added * get_attestation_data_slot added * decrease_balance added * increase_balance added * is_slashable_validator added * get_previous_epoch modified * get_active_validator_indices modified * get_randao_mix modified * get_active_index_root modified * generate_seed modified * get_beacon_proposer_index modified * removed methods * replacce assert * bug fixes * bug fixes * couture * bug fixes * best dev evar * bug fixes * oops
This was referenced May 2, 2020
This was referenced May 7, 2020
Closed
StefanBratanov
referenced
this pull request
in StefanBratanov/teku
Jul 29, 2022
…ey-override Complement PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to resolve: