[Issue 4023] Migrate altair validator constants #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
commented
Jun 3, 2021
| @@ -68,7 +66,7 @@ | |||
| private final BLSSignature nonAggregatorSignature = | |||
| BLSSignature.fromBytesCompressed( | |||
| Bytes.fromHexString( | |||
| "0xae401f767ab1917f925fe299ad51a57d52f7cc80deb1cc20fa2b3aa983e4e4d23056d79f01f3c97e29c8905da17e70e30c2a3f6bdd83dbc4ddf530e02e8f4d7ba22260e12e5f5fe7875b48e79660615b275597e87b2d33e076664b3da1737852")); | |||
| "0xce401f767ab1917f925fe299ad51a57d52f7cc80deb1cc20fa2b3aa983e4e4d23056d79f01f3c97e29c8905da17e70e30c2a3f6bdd83dbc4ddf530e02e8f4d7ba22260e12e5f5fe7875b48e79660615b275597e87b2d33e076664b3da1737852")); | |||
There was a problem hiding this comment.
The modulus math changed when I removed the customized value for TARGET_AGGREGATORS_PER_SYNC_SUBCOMMITTEE - just tweaked this variable until I found a value that would fail the SyncCommitteeUtil.isSyncCommitteeAggregator() check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Migrate altair constant to
ValidatorConstants.Fixed Issue(s)
Fixes #4023
Documentation
documentationlabel to this PR if updates are required.Changelog