Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implements engine_preparePayload and engine_getPayload (#4346) #4399

Merged
merged 3 commits into from
Sep 22, 2021
Merged

implements engine_preparePayload and engine_getPayload (#4346) #4399

merged 3 commits into from
Sep 22, 2021

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Sep 21, 2021

Changelog

  • engine_preparePayload client implementation and call integrated in block proposal duty preparation
  • engine_getPayload client implementation and call integrated in block proposal duty production
  • consensus_assembleBlock removed

Nashatyrev
Nashatyrev reviewed Sep 21, 2021
View reviewed changes
Copy link
Contributor

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically fine with just exception of slot->payload cache

ethereum/spec/src/main/java/tech/pegasys/teku/spec/logic/common/util/ExecutionPayloadUtil.java Outdated Show resolved Hide resolved
@tbenr
Copy link
Contributor Author

tbenr commented Sep 21, 2021

@Nashatyrev
As per offline discussions, moved slotToPayloadIdMap to BlockFactory.

I Also fixed a bounce of presumed bugs while determining parentBlockHash in preparePayload and getPayload (always in BlockFactory)

I added a parentBlock hash check too.

Nashatyrev
Nashatyrev approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr merged commit ac8fb1c into Consensys:merge-interop Sep 22, 2021
@tbenr tbenr deleted the prepare_and_get_payload branch September 22, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashatyrev Nashatyrev Nashatyrev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbenr @Nashatyrev