Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merge] Migrate PowBlock to ssz #4429

Merged
merged 2 commits into from
Oct 1, 2021
Merged

[Merge] Migrate PowBlock to ssz #4429

merged 2 commits into from
Oct 1, 2021

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Sep 29, 2021 •
edited
Loading

Migrates PowBlock to be an SSZ Container. It is a requirement to be able to run merge reference tests
implemented new SszUInt256 primitive type

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr
migrate PowBlock to SSZ Container
94126e5 
implemented new `SszUInt256`
Nashatyrev
Nashatyrev approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
Just need to adjust endianess when converting UInt256 <-> Bytes32

@tbenr
Copy link
Contributor Author

tbenr commented Sep 30, 2021

@Nashatyrev should be ok now

@Nashatyrev
Copy link
Contributor

Lets's merge

@tbenr tbenr merged commit 69dfa7b into Consensys:merge-interop Oct 1, 2021
@Nashatyrev Nashatyrev mentioned this pull request Oct 1, 2021
Closed
20 tasks
@tbenr tbenr deleted the migrate_powblock_to_ssz branch October 1, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashatyrev Nashatyrev Nashatyrev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbenr @Nashatyrev