-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merge] Make Teku working with Geth EE #4431
Merged
Nashatyrev
merged 19 commits into
Consensys:merge-interop
from
Nashatyrev:merge/geth-api
Oct 1, 2021
Merged
[Merge] Make Teku working with Geth EE #4431
Nashatyrev
merged 19 commits into
Consensys:merge-interop
from
Nashatyrev:merge/geth-api
Oct 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of `parentHash`
…quest object instead of a list of parameters
tbenr
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some comments
util/src/main/resources/tech/pegasys/teku/util/config/configs/mainnet.yaml
Outdated
Show resolved
Hide resolved
...in/java/tech/pegasys/teku/services/powchain/execution/client/Web3JExecutionEngineClient.java
Outdated
Show resolved
Hide resolved
Updated to the final interop spec version. Mostly |
Something weird happening with CI checks indication on github :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
A lot of API compatibility issues fixed
With these changes Teku works with Geth EE , successfully produces and imports blocks with
ExecutionPayload
composed by Geth EERun instructions
NOTE: as per spec the
GENESIS_GAS_LIMIT
should be30 000 000
so make sure (or change) the Geth genesis file to have value"gasLimit": "0x1C9C380"
. With that value the block hash would be0x3b8fb240d288781d4aac94d3fd16809ee413bc99294a085798a589dae51ddd4a
Fixed Issue(s)
Documentation
documentation
label to this PR if updates are required.Changelog