Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge] Make Teku working with Geth EE #4431

Merged
merged 19 commits into from
Oct 1, 2021

Conversation

Nashatyrev
Copy link
Contributor

@Nashatyrev Nashatyrev commented Sep 30, 2021

PR Description

A lot of API compatibility issues fixed

With these changes Teku works with Geth EE , successfully produces and imports blocks with ExecutionPayload composed by Geth EE

Run instructions

  1. Build and start Geth EE as described here
    NOTE: as per spec the GENESIS_GAS_LIMIT should be 30 000 000 so make sure (or change) the Geth genesis file to have value "gasLimit": "0x1C9C380". With that value the block hash would be 0x3b8fb240d288781d4aac94d3fd16809ee413bc99294a085798a589dae51ddd4a
  2. Generate consensus genesis state:
> teku genesis mock \
  --eth1-block-hash 0x3b8fb240d288781d4aac94d3fd16809ee413bc99294a085798a589dae51ddd4a \
  --output-file ./local-genesis.ssz \ 
  --network=minimal \
  --Xnetwork-altair-fork-epoch=0 \
  --Xnetwork-merge-fork-epoch=0 \
  --validator-count=256
  1. Run a Teku node:
> teku \
  --eth1-endpoints=http://localhost:8545 \
  --ee-fee-recipient-address=0xfe3b557e8fb62b89f4916b721be55ceb828dbd73 \
  --Xinterop-enabled=true \
  --Xinterop-number-of-validators=256 \
  --Xinterop-owned-validator-start-index=0 \
  --Xinterop-owned-validator-count=256 \
  --network=minimal \
  --Xnetwork-altair-fork-epoch=0 \ 
  --Xnetwork-merge-fork-epoch=0 \ 
  --p2p-enabled=false \
  --initial-state ./local-genesis.ssz

Fixed Issue(s)

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments

@Nashatyrev
Copy link
Contributor Author

Updated to the final interop spec version. Mostly engine_preparePayload return type reverted back to object instead of value

@Nashatyrev Nashatyrev mentioned this pull request Oct 1, 2021
20 tasks
@Nashatyrev
Copy link
Contributor Author

Something weird happening with CI checks indication on github :/

@Nashatyrev Nashatyrev merged commit a509c06 into Consensys:merge-interop Oct 1, 2021
@Nashatyrev Nashatyrev deleted the merge/geth-api branch November 18, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants