[Merge] Spec v1.1.1 adoption #4445
Conversation
| return new ExecutionPayloadHeader( | ||
| Bytes32.ZERO, | ||
| Bytes20.ZERO, | ||
| Bytes32.ZERO, | ||
| Bytes32.ZERO, | ||
| Bytes.wrap(new byte[SpecConfig.BYTES_PER_LOGS_BLOOM]), | ||
| blockHash, | ||
| UInt64.ZERO, | ||
| UInt64.valueOf(genesisParams.genesisGasLimit), | ||
| UInt64.ZERO, | ||
| UInt64.valueOf(genesisParams.genesisTime), | ||
| Bytes.EMPTY, | ||
| Bytes32.rightPad( | ||
| Bytes.ofUnsignedLong(genesisParams.genesisBaseFee, ByteOrder.LITTLE_ENDIAN)), | ||
| blockHash, | ||
| Bytes32.ZERO); |
There was a problem hiding this comment.
I'm a little surprised we don't wind up needing to get the genesis payload from the EL client. The genesis state root won't be zero for example. I suspect if all CL clients use the same values it probably works fine but it could cause confusion if these zero'd values are sent as part of messages to the EL client as they won't match what it expects.
There was a problem hiding this comment.
TBH I was thinking of passing EL http API address to retrieve the head block and make genesis execution payload from it, but it seemed a bit kind of overcomplicated to have a EL running for generating genesis.
We discussed with Mikhail about should we pass the full ExecutionPayloadHeader for genesis mock or just a couple of additional params (genesisGasLimit and genesisBaseFee) and fill other with zeroes. Other fields don't affect anything than genesis state hash root. So if you are doing standalone mocking you shouldn't care about those fields. If you are doing some kind of interop you may always pick the genesis.ssz from the other party.
…nt/previousVersion
…nesis epoch both fork versions should be the same
# Conflicts: # ethereum/spec/src/main/java/tech/pegasys/teku/spec/config/SpecConfigBuilder.java # ethereum/spec/src/main/java/tech/pegasys/teku/spec/config/SpecConfigMerge.java # ethereum/spec/src/test/resources/tech/pegasys/teku/spec/config/invalid/invalidPreset_unknown.yaml # ethereum/spec/src/test/resources/tech/pegasys/teku/spec/config/invalid/invalidPreset_wrongType.yaml # ethereum/spec/src/test/resources/tech/pegasys/teku/spec/config/invalid/multifile_dupFields/config.yaml # ethereum/spec/src/test/resources/tech/pegasys/teku/spec/config/standard/mainnet.yaml # ethereum/spec/src/test/resources/tech/pegasys/teku/spec/config/standard/minimal.yaml # teku/src/integration-test/resources/tech/pegasys/teku/cli/subcommand/test-spec.yaml # util/src/main/resources/tech/pegasys/teku/util/config/configs/mainnet.yaml # util/src/main/resources/tech/pegasys/teku/util/config/configs/minimal.yaml # util/src/main/resources/tech/pegasys/teku/util/config/configs/prater.yaml # util/src/main/resources/tech/pegasys/teku/util/config/configs/pyrmont.yaml # util/src/test/resources/tech/pegasys/teku/util/config/invalid/invalidPresetType.yaml # util/src/test/resources/tech/pegasys/teku/util/config/invalid/unknownPreset.yaml
PR Description
Adopt Spec v1.1.1 changes:
GENESIS_GAS_LIMIT&GENESIS_BASE_FEE_PER_GASconstants--genesis-gas-limitand--genesis-base-feeCLI options when generatinggenesis mockForkis scheduled for the genesis epoch use same value forcurrent/previousVersionFixed Issue(s)
Part of the #4226
Documentation
documentationlabel to this PR if updates are required.Changelog