[Merge] Move execution payload validation out of state transition #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows nodes to be added optimistically that are later marked valid or invalid with separate methods to find the strict and optimistic head.
Execution fo the payload is now done asynchronously post-block import.
…in the right direction.
tbenr
changed the title
tbenr
reviewed
Nov 17, 2021
| private final EventThread forkChoiceExecutor; | ||
| private final SignedBeaconBlock block; | ||
| private final ExecutionEngineChannel executionEngine; | ||
| private SafeFuture<ExecutePayloadResult> result; |
There was a problem hiding this comment.
is there a reason why you don't use Optional here?
There was a problem hiding this comment.
Mostly because Optional<SafeFuture<ExecutePayloadResult>> is kind of awful and it's entirely internal. The class did get a fair bit bigger since I made that decision though so it probably is worth changing to Optional.
tbenr
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Moves execution payload validation out of state transition to be done asynchronously, enabling optimistic sync.
There are still quite a few loose ends here but want to see what mess this makes of tests.
Fixed Issue(s)
#4599
fixes #4348
Documentation
documentationlabel to this PR if updates are required.Changelog