Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helpers): renamed helper methods isMerge* -> isMergeTransition* #4778

Merged
merged 4 commits into from
Dec 13, 2021
Merged

feat(helpers): renamed helper methods isMerge* -> isMergeTransition* #4778

merged 4 commits into from
Dec 13, 2021

Conversation

arhamj
Copy link
Contributor

@arhamj arhamj commented Dec 10, 2021

PR Description

Fixed Issue(s)

Documentation

  • NA

Changelog

  • NA

ajsutton
ajsutton approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - it looks great, just needed to run ./gradlew spotlessApply to fix the formatting issues from the longer names. I've done that and pushed it up so should be ready to go when the build finishes.

@ajsutton ajsutton merged commit cdce29c into Consensys:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arhamj @ajsutton