Apply execution engine timeouts #5337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply timeouts to execution engine requests as per the latest spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Apply timeouts to execution engine requests as per the latest spec.
Web3j doesn't allow setting the actual http timeout separate for different request types and web sockets and IPC don't have any concept of request timeouts at all. So we handle the timeout via the future and set the HTTP read timeout to the longest timeout we need to ensure it doesn't abort the connection before the timeout is reached.
Fixed Issue(s)
fixes #5302
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog