Move web3j logic in executionclient module to a separate package #5475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
May 12, 2022
.gitignore
Outdated
Comment on lines
32
to
33
| web3j/ | ||
| !**/executionclient/web3j/ |
There was a problem hiding this comment.
We can probably remove this ignore entirely. I think it used to be there because we generated the deposit contract APIs via web3j but we don't do that anymore.
There was a problem hiding this comment.
Great, will remove it then. Would be cleaner.
StefanBratanov
force-pushed
the
move_web3j_package
branch
2 times, most recently
from
d693211
to
d74f7d4
Compare
StefanBratanov
force-pushed
the
move_web3j_package
branch
from
d74f7d4
to
eb388cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Move web3j logic in
executionclientmodule toweb3jpackage inside the module.Fixed Issue(s)
related to #5396
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog