-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MEV-Boost\Builder] Unhide hidden params for mev-boost\builder #5860
[MEV-Boost\Builder] Unhide hidden params for mev-boost\builder #5860
Conversation
The The other two options possibly should be named so they're tied together (so they'd be Do we need to expose |
yeah, agree, not particularly user friendly.
I prefer this option. Btw the
the problem is that this option is for the VC. So we automatically enable it when using An option could be to simply enable the blinded block flow by default (which saves bandwidth for Bellatrix blocks), and warn if user disable it (which could prevent mev when using validators-proposer-config) |
If we're really confident in our fallback that would be reasonable. Otherwise it could easily break for a lot of people. |
a beginning could be to enable it now in all our merged testnets |
398821f
to
e7740b0
Compare
96add12
to
e235f14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me as well
teku/src/main/java/tech/pegasys/teku/cli/options/ExecutionLayerOptions.java
Outdated
Show resolved
Hide resolved
e235f14
to
fd460f2
Compare
CLI argument changes changes:
--eb-endpoint
->--builder-endpoint
--Xvalidators-registration-default-enabled
->--validators-builder-registration-default-enabled
--Xvalidators-registration-timestamp-override
->--validators-builder-registration-timestamp-override
--Xvalidators-proposer-blinded-blocks-enabled
->--validators-proposer-blinded-blocks-enabled
--Xvalidators-registration-default-gas-limit
->--Xvalidators-builder-registration-default-gas-limit
--Xvalidators-registration-sending-batch-size
->--Xvalidators-builder-registration-sending-batch-size
Relaxed proposerConfig json rule to allow per pubkey configuration to have empty\null
fee_recipient
.default_config
still requires it.Extended
proposer-config
json referenced by the existing--validators-proposer-config
A draft note covering the usage of the changes: https://hackmd.io/@StefanBratanov/BkMlo1RO9
closes #5396
Documentation content
Intro
When The Merge completes, Consensus Clients will be responsible for proposing blocks containing an Execution Payload (the Ethereum PoW Block in the context of PoS) obtained from their local Execution Clients via the
Engine API
.Optionally, instead of building it locally, a Consensus Clients can configure an external “builder” to delegate the Execution Payload construction to.
This new interface is called
Builder API
and has been introduced to standardize the interaction with MEV providers, in the effort of making it easily accessible and interchangeable.Teku supports this interface and allows to configure the Beacon Node to a single
builder endpoint
that will be trusted for generating Execution Payload. In case of failures or non timely responses, Teku will use the payload produced by the local Execution Client (the one specified withee-endpoint
)The most common deployment is to run an specialised software (i.e. mev-boost) and configure it as the
builder endpoint
. This software will be responsible for requesting a payload proposal from several entities (called relays) and selecting the best bid.Important Note
In deployment where Validator Client runs in a separate process and communicate with a Beacon Node via rest API, make sure that the Beacon Node supports the blinded block API.
new CLI args
--builder-endpoint
Optionally specify the Builder API to delegate the execution payload construction to.
example(
--builder-endpoint=http://127.0.0.1:18550/
)--validators-builder-registration-default-enabled
When enabled, all validators managed by the validator client will be configured to register to builder endpoint and will use it when proposing a block.
--validators-builder-registration-timestamp-override
This parameter allows to specify a timestamp that will be used when registering validators against the builder endpoint. It is only useful in deployments where validator keys are shared between multiple nodes (Obol, SSV or similar)
--validators-proposer-blinded-blocks-enabled
This enables blinded blocks flow, a prerequisite for the usage of the builder endpoint. When
--validators-builder-registration-default-enabled
is enabled this option will be enabled automatically. It requires explicit enablement when used in conjunction with--validators-proposer-config
.CLI args changes
—validators-proposer-config
The specified config file now supports a new
builder
attribute that can be specified in thedefault_config
as well as for each public keys.in
builder
enabled
indicates if the applicable validator key should register to and use the builder endpoint when proposing blocks.gas_limit
is an optional parameter that allows to specify the preferredgas_limit
that the builder should respect. When not specified the default value30000000
will be used.fee_recipient
attribute becomes optional in a public key config, but remains mandatory in thedefault_config
Documentation
doc-change-required
label to this PR if updates are required.Changelog