Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finalized to ObjectAndMetaData #6569

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Dec 8, 2022

PR Description

This is the first step to making it available via the API. It was big enough it seemed worth doing the actual change of response types in a follow up PR.

Fixed Issue(s)

#6406

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

This is the first step to making it available via the API. It was big enough it seemed worth doing the actual change of response types in a follow up PR.
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsutton ajsutton merged commit 6f4835d into Consensys:master Dec 8, 2022
@ajsutton ajsutton deleted the add-finalized-metadata branch December 8, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants