Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finalized to API responses #6570

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Add finalized to API responses #6570

merged 4 commits into from
Dec 8, 2022

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Dec 8, 2022

PR Description

Add finalized metadata to API responses.

Also adds execution_optimistic to the GetStateRandao endpoint which was missing it.

Fixed Issue(s)

#6406

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

rolfyone
rolfyone approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsutton ajsutton merged commit bec9621 into Consensys:master Dec 8, 2022
@ajsutton ajsutton deleted the add-finalized-to-response branch December 8, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajsutton @rolfyone