Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Error Prone StringCaseLocaleUsage warning #7315

Merged
merged 6 commits into from
Jun 29, 2023
Merged

Fix Error Prone StringCaseLocaleUsage warning #7315

merged 6 commits into from
Jun 29, 2023

Conversation

courtneyeh
Copy link
Contributor

fixes #7223

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

StefanBratanov
StefanBratanov approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@courtneyeh courtneyeh merged commit b08b8c0 into Consensys:master Jun 29, 2023
4 checks passed
@courtneyeh courtneyeh deleted the locale-usage branch June 29, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanBratanov StefanBratanov StefanBratanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review Error Prone StringCaseLocaleUsage warning
2 participants
@courtneyeh @StefanBratanov