Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parentBeaconBlockRoot to EngineNewPayloadV3 #7335

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Add parentBeaconBlockRoot to EngineNewPayloadV3 #7335

merged 5 commits into from
Jul 6, 2023

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Jul 6, 2023 •
edited
Loading

updates the engine API and computeNewPayloadRequest in blockProcessor to pass the value.

fixes #7263

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

StefanBratanov
StefanBratanov approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a test improvement that could be done

...src/test/java/tech/pegasys/teku/spec/logic/versions/deneb/block/BlockProcessorDenebTest.java Show resolved Hide resolved
@tbenr tbenr enabled auto-merge (squash) July 6, 2023 10:52
@tbenr tbenr merged commit bc89929 into Consensys:master Jul 6, 2023
@tbenr tbenr deleted the 4788_add_beacon_block_root_in_new_payload_V3 branch July 6, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanBratanov StefanBratanov StefanBratanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes for EIP-4788
2 participants
@tbenr @StefanBratanov