Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Kiln and Ropsten as supported networks #7343

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Remove Kiln and Ropsten as supported networks #7343

merged 3 commits into from
Jul 10, 2023

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Jul 9, 2023 •
edited
Loading

PR Description

Kiln and Ropsten have been shut down for a long time, so there is no point in supporting them as a --network option.

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov changed the title Remove Kiln as a supported network Remove Kiln and Ropsten as supported networks Jul 9, 2023
@lucassaldanha
Copy link
Member

lucassaldanha commented Jul 9, 2023 •
edited
Loading

Might be worth adding a changelog entry? Not sure if you considered the fact that ppl using these configs (if any) won't be able to upgrade their nodes.

lucassaldanha
lucassaldanha reviewed Jul 9, 2023
View reviewed changes
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing my approval for further discussion.

@rolfyone rolfyone marked this pull request as draft July 9, 2023 22:30
@rolfyone rolfyone requested a review from lucassaldanha July 9, 2023 22:30
@rolfyone rolfyone marked this pull request as ready for review July 9, 2023 22:30
@rolfyone
Copy link
Contributor

rolfyone commented Jul 9, 2023 •
edited
Loading

What's the logic behind removing ropsten?

ropsten.beaconcha.in shows blocks being produced..

@StefanBratanov
Copy link
Contributor Author

What's the logic behind removing ropsten?

ropsten.beaconcha.in shows blocks being produced..

Ropsten has been shut down since December last year though. ropsten.beaconcha.in points to mainnet for some reason and when you try connecting to it, there are no peers, etc.

@tbenr
Copy link
Contributor

tbenr commented Jul 10, 2023

https://blog.ethereum.org/2022/11/30/ropsten-shutdown-announcement

@StefanBratanov
Copy link
Contributor Author

Prysm also removed option few releases back: prysmaticlabs/prysm#12058

@lucassaldanha
Copy link
Member

I got confused by ropsten.beaconcha.in

@rolfyone
Copy link
Contributor

ok all good, just no context as to why we were removing support for a network still progressing, but happy now.

@StefanBratanov
Copy link
Contributor Author

I got confused by ropsten.beaconcha.in

Yeah same. I will bring it up in their discord.

@StefanBratanov StefanBratanov enabled auto-merge (squash) July 10, 2023 07:46
@StefanBratanov StefanBratanov merged commit b6a6617 into Consensys:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

@lucassaldanha lucassaldanha lucassaldanha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StefanBratanov @lucassaldanha @rolfyone @tbenr