Initial cut of late block reorg #7789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- requires development flag to enable - will introduce debug logging in ForkChoice and RecentChainData so that we can observe behaviours. - Needed tweak some areas while I was non-validator node testing. Will push this to a validating node and enable debugging so that I can make broader observations as to how things are working. If anything needs tweaking we may miss some block proposals so will likely choose a smaller node rather than a bigger node. Signed-off-by: Paul Harris <paul.harris@consensys.net>
Also cleaned up some debug logs Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
|
is this actually ready for review\merge or is still under testing? |
Feel free to review, waiting to see a block currently to see if there's follow on issues but it may need to be installed to more nodes for that to happen |
- added some extra debugging to get a rough idea of proposal timings also. This should drastically reduce the chances of the late block reorg feature taking time to decide its direction. Signed-off-by: Paul Harris <paul.harris@consensys.net>
…onsistent with the non late block reorg way of getting state. Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
rolfyone
added a commit
to rolfyone/teku
that referenced
this pull request
Jan 24, 2024
Removed state from isHeadWeak and isParentStrong - these values now get cached on updateHeadTransaction Renamed newSlot to proposalSlot Added a function to cache weights, as they're expensive to compute and we shouldn't need to compute each call. debug logging added in recentChainData at decission points. partially addresses Consensys#6595 - this is a subset of Consensys#7789 Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
|
will close for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will push this to a validating node and enable debugging so that I can make broader observations as to how things are working. If anything needs tweaking we may miss some block proposals so will likely choose a smaller node rather than a bigger node.
partially addresses #6595
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog