Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DEFAULT_BUILDER_BID_COMPARE_FACTOR to 90 #8108

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

fredriksvantes
Copy link
Contributor

PR Description

In order to help increase censorship resistance, I propose to change the default DEFAULT_BUILDER_BID_COMPARE_FACTOR to 90. This means validators will prioritize local block building unless the bid from the external block builder is 10% or higher than what the validator would receive when building locally.

Looking at (stats), it can be seen that currently 63.7% of external builders are censoring transactions compared to 8.53% of validators who do local block building, so setting a minimum 10% as default can help increase the overall censorship resistance of the network.

It is still easy for users to opt out of this by manually setting the flag to 100, but many are likely to use the default which could help with censorship resistance for the network.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@fredriksvantes
Copy link
Contributor Author

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr merged commit 344b134 into Consensys:master Mar 21, 2024
16 checks passed
@mcdee
Copy link
Contributor

mcdee commented Mar 29, 2024

Just seen this; how does it work in practice? https://ethereum.github.io/beacon-APIs/#/ValidatorRequiredApi/produceBlockV3 states about the builder boost factor "If this parameter is not provided then it should be treated as having the default value of 100", so this PR appears to clash with the API specification.

@fredriksvantes
Copy link
Contributor Author

Just seen this; how does it work in practice? https://ethereum.github.io/beacon-APIs/#/ValidatorRequiredApi/produceBlockV3 states about the builder boost factor "If this parameter is not provided then it should be treated as having the default value of 100", so this PR appears to clash with the API specification.

Good catch @mcdee , while "should" is more permissive than "must", I opted to make a PR ( ethereum/beacon-APIs#438 ) that doesn't define default as any specific value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants