provide ssz bitvector OR function #8302
Conversation
Co-authored-by: mehdi-aouadi <mehdi.aouadi@consensys.net>
...e/ssz/src/main/java/tech/pegasys/teku/infrastructure/ssz/collections/impl/BitvectorImpl.java
Outdated
Show resolved
Hide resolved
...sz/src/main/java/tech/pegasys/teku/infrastructure/ssz/collections/impl/SszBitvectorImpl.java
Outdated
Show resolved
Hide resolved
| @@ -76,6 +76,16 @@ public List<Integer> getSetBitIndices() { | |||
| return data.stream().boxed().toList(); | |||
| } | |||
|
|
|||
| public BitvectorImpl or(final BitvectorImpl other) { | |||
| if (other.getSize() > getSize()) { | |||
There was a problem hiding this comment.
i'd think we want to make sure the sizes match exactly if we're doing a bitwise or, otherwise we'll be needing to decide if the stragglers are left or right etc... other.size() != getSize
There was a problem hiding this comment.
mm yes but this mimics the BitlistImpl or which does the same. We may say that this is a vector so it could be more strict but I'm more on the side to have a similar behavior.
There was a problem hiding this comment.
its probably bad behaviour to mimic... you can mis-match and do bitwise or partially.... future @tbenr problem to find i guess...
There was a problem hiding this comment.
Is this feature really used somewhere? (I mean or with smaller list/vector)
If yes we could split it to several safer steps, but it could affect performance
There was a problem hiding this comment.
k lets be more stringent and maybe open in the future.
@zilm13 we won't (at least for 7549)
There was a problem hiding this comment.
i really do think we're better off making this one right rather than copying a bad idea - especially on a bitwise or... at least then we know why its a greater than if it causes a break...
provides bitvecor OR, useful for 7549
Related to #7965
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog