Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using atomic file writer to update data-storage-mode.txt #8363

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Using atomic file writer to update data-storage-mode.txt #8363

merged 2 commits into from
Jun 11, 2024

Conversation

lucassaldanha
Copy link
Member

@lucassaldanha lucassaldanha commented Jun 10, 2024 •
edited
Loading

This is related to #8357 and should prevent instances when we end up with the data-storage-mode.txt file empty (and invalid).

rolfyone
rolfyone approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, possibly worth a changelog entry

@lucassaldanha lucassaldanha enabled auto-merge (squash) June 10, 2024 21:34
@lucassaldanha lucassaldanha merged commit 0210e42 into Consensys:master Jun 11, 2024
16 checks passed
@lucassaldanha lucassaldanha deleted the atomic-fw branch June 11, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucassaldanha @rolfyone