Add floodPublish CLI flag
#8610
Open
+69
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatyaRyazantseva
force-pushed
the
8559
branch
from
74b3c69
to
1a15d12
Compare
Nashatyrev
reviewed
Sep 18, 2024
| @@ -284,6 +288,11 @@ public Builder peerRequestLimit(final Integer peerRequestLimit) { | |||
| return this; | |||
| } | |||
|
|
|||
| public Builder isFloodPublishEnabled(final Boolean floodPublishEnabled) { | |||
| isFloodPublishEnabled = floodPublishEnabled; | |||
There was a problem hiding this comment.
I would add explicit this. to be in line with the rest of code
Nashatyrev
reviewed
Sep 18, 2024
| @@ -42,6 +43,7 @@ public class P2PConfig { | |||
| public static final int DEFAULT_BATCH_VERIFY_QUEUE_CAPACITY = 15_000; | |||
| public static final int DEFAULT_BATCH_VERIFY_MAX_BATCH_SIZE = 250; | |||
| public static final boolean DEFAULT_BATCH_VERIFY_STRICT_THREAD_LIMIT_ENABLED = false; | |||
| public static final boolean DEFAULT_FLOOD_PUBLISH_ENABLED = true; | |||
There was a problem hiding this comment.
Doesn't it duplicate the same constant in GossipConfig ?
Nashatyrev
approved these changes
Sep 18, 2024
tbenr
reviewed
Sep 18, 2024
| paramLabel = "<BOOLEAN>", | ||
| showDefaultValue = Visibility.ALWAYS, | ||
| description = "Enables gossip 'floodPublish' feature", | ||
| hidden = true, |
There was a problem hiding this comment.
unit tests detected this is declared hidden even if it is not a --X config. You should remove this.
|
@tbenr ready for the test review |
tbenr
added
the
doc-change-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add
--p2p-flood-publish-enabledCLI flag to enable/disable flood publishing.Fixed Issue(s)
fixes #8559
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog