Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clarified Variable Reference Update unixStartScript.txt #8958

Closed
wants to merge 1 commit into from

Conversation

annwag
Copy link

@annwag annwag commented Dec 26, 2024

PR Description

I noticed a small but potentially confusing redundancy in the startup script. Specifically, the JAVA_OPTS variable is mentioned twice in the following comment:

#   * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments,  

This duplicate mention doesn't add value and could lead to misinterpretation. I've adjusted the line to ensure clarity:

#   * DEFAULT_JVM_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments,  

This update simplifies the comment and aligns it with the intended meaning.
No functional changes were made; this is purely a documentation improvement to enhance readability and reduce ambiguity.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr
Copy link
Contributor

tbenr commented Dec 28, 2024

against contribution guidelines. closing.

@tbenr tbenr closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants