Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capella changes #722

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Capella changes #722

merged 5 commits into from
Feb 23, 2023

Conversation

usmansaleem
Copy link
Contributor

PR Description

Update Web3Signer to sign block for Capella spec.

  • Update OpenApi spec
  • Introduced manual fork overridden cli option
  • Update Acceptance Test
  • Update Teku library to 23.2.0

Fixed Issue(s)

#682

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@usmansaleem
Eth2 OpenApi spec
831d042 
 -- add block request definition for Capella
@usmansaleem
Capella changes
05e2fad
@usmansaleem usmansaleem added the TeamCerberus Under active development by TeamCerberus @Consensys label Feb 23, 2023
@usmansaleem usmansaleem self-assigned this Feb 23, 2023
@usmansaleem usmansaleem requested a review from jframe February 23, 2023 02:40
jframe
jframe reviewed Feb 23, 2023
View reviewed changes
...ests/src/test/java/tech/pegasys/web3signer/tests/signing/Eth2BlockSigningAcceptanceTest.java Outdated
name = "#{index} - Empty block request for spec {0} should return bad request status")
@EnumSource(
value = SpecMilestone.class,
names = {"BELLATRIX", "CAPELLA"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this only apply to bellatrix and capella? should also include phase0 and altair?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, updated it to cover phase0 and altair as well.

core/src/main/resources/openapi-specs/eth2/signing/schemas.yaml
version:
type: string
enum:
- CAPELLA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying that we need to define this just for the enum value. But think we have to do this way with the current API.

@usmansaleem usmansaleem marked this pull request as ready for review February 23, 2023 04:24
jframe
jframe approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem merged commit 7edd73b into Consensys:master Feb 23, 2023
@usmansaleem usmansaleem deleted the capella_changes branch February 23, 2023 05:52
@james-prysm james-prysm mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees

@usmansaleem usmansaleem

Labels
TeamCerberus Under active development by TeamCerberus @Consensys
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usmansaleem @jframe