Remove dist folder from git and add on npm files #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhonmike
approved these changes
Jun 18, 2018
fernahh
changed the title
cirocfc
approved these changes
Jun 18, 2018
package.json
Outdated
| "repository": "ContaAzul/creditcard.js", | ||
| "files": [ | ||
| "lib", | ||
| "dist", | ||
| "src" |
There was a problem hiding this comment.
@fernahh should the src folder be published to npm?
package.json
Outdated
| @@ -2,10 +2,10 @@ | |||
| "name": "creditcard.js", | |||
| "version": "2.1.3", | |||
| "description": "A simple library for credit-card validation in JavaScript", | |||
| "main": "src/creditcard.js", | |||
| "main": "dist/creditcard.min.js", | |||
There was a problem hiding this comment.
@fernahh It is not better to make the package point to the unminified version of the library and leave the build system of the end-user (like webpack) take care from the minification process?
dedicio
added a commit
that referenced
this pull request
Jan 18, 2021
* Add Rollup as task runner (#64) * Add rollup config and remove unused dependencies * Update karma config to use rollup * Use ESModules * Update dist files * Added templates to create pullrequest and issues (#75) * Added templates to create pullrequest and issues * Modify language template * Removed support to bower and add support to yarn (#74) * Removed support to bower and add support to yarn * Remove dist folder and ignore in .gitignore file * Adds new installation instruction * Remove folder dist. * [v3] Use Jest for tests, added code coverage reports (#77) * replace karma with jest * make tests jest compatible * publish coveralls reports in travis * removed dependencies from package.json * removed karma configs * added coverage threshold configs * Export functions instenead of a constructor (#78) * migrating files to functional programming * fix specs files to import the functional lib * updated documentation fro use of functional code * fix example using the functional lib * update package-lock * update dist * adjusting function name sum * Add Prettier as a formatter tool (#80) * Add prettier configuration * Format files with prettier config * Add husky for pre-commit hook * Update libraries to fix vulnerabilities (#81) * Remove dist folder from git and add on npm files (#83) * Cleanup npmignore and add dist file as main files * Remove dist folder * Add dist folder on gitignore * Remove minified file from dist * Create CHANGELOG file with 0.1.2 version (#86) * updating dependencies * dependencies update * Remove yarn lock file * Update dependencies * Update docs * Add bins new bins and cards - New cards: banescard, maxxvan, cabal, goodCard - New bins for mastercard and hipercard * Add bins new bins and cards - New cards: banescard, maxxvan, cabal, goodCard - New bins for mastercard and hipercard * fix false positives on luhn spec * Use a better directory structure * Remove static example * Use Array#find on getCreditCardNameByNumber * Remove mutables values from isSecurityCodeValid * Remove ifs from isExpirationDateValid * Remove mutables values from isValid function * feat: refactor expiration date validation * fix: lint formatter * feat: refactor format full year * feat: config github actions on v3 * feat: refactor security code length validation * feat: add jcb card * feat: add coverage to actions * feat: update dependencies * chore: add release-it config * feat: add tokenref * feat: add conventional changelog * chore: update version * feat: upgrade to a more functional approach BREAKING CHANGE: this version does not require an instance in order to work. Please, check the diff. * feat: add minified package Co-authored-by: Luiz Fernando Rodrigues <fernahh@gmail.com> Co-authored-by: Edmo Lima <devedmo@gmail.com> Co-authored-by: Carlos Roberto Gomes Junior <carlos.rberto@gmail.com> Co-authored-by: Jhon Mike <developer@jhonmike.com.br> Co-authored-by: Lucas F. Bittencurt <lucasfilipeb@gmail.com> Co-authored-by: Ciro Ferreira da Cruz <ciro.cfc@gmail.com> Co-authored-by: Ciro Ferreira da Cruz <ciro.cruz@contaazul.com> Co-authored-by: Guilherme Tavares <zetavares.rib@gmail.com> Co-authored-by: Mateus Craveiro <mccraveiro@gmail.com>
cirocfc
added a commit
that referenced
this pull request
Jan 18, 2021
* Add Rollup as task runner (#64) * Add rollup config and remove unused dependencies * Update karma config to use rollup * Use ESModules * Update dist files * Added templates to create pullrequest and issues (#75) * Added templates to create pullrequest and issues * Modify language template * Removed support to bower and add support to yarn (#74) * Removed support to bower and add support to yarn * Remove dist folder and ignore in .gitignore file * Adds new installation instruction * Remove folder dist. * [v3] Use Jest for tests, added code coverage reports (#77) * replace karma with jest * make tests jest compatible * publish coveralls reports in travis * removed dependencies from package.json * removed karma configs * added coverage threshold configs * Export functions instenead of a constructor (#78) * migrating files to functional programming * fix specs files to import the functional lib * updated documentation fro use of functional code * fix example using the functional lib * update package-lock * update dist * adjusting function name sum * Add Prettier as a formatter tool (#80) * Add prettier configuration * Format files with prettier config * Add husky for pre-commit hook * Update libraries to fix vulnerabilities (#81) * Remove dist folder from git and add on npm files (#83) * Cleanup npmignore and add dist file as main files * Remove dist folder * Add dist folder on gitignore * Remove minified file from dist * Create CHANGELOG file with 0.1.2 version (#86) * updating dependencies * dependencies update * Remove yarn lock file * Update dependencies * Update docs * Add bins new bins and cards - New cards: banescard, maxxvan, cabal, goodCard - New bins for mastercard and hipercard * Add bins new bins and cards - New cards: banescard, maxxvan, cabal, goodCard - New bins for mastercard and hipercard * fix false positives on luhn spec * Use a better directory structure * Remove static example * Use Array#find on getCreditCardNameByNumber * Remove mutables values from isSecurityCodeValid * Remove ifs from isExpirationDateValid * Remove mutables values from isValid function * feat: refactor expiration date validation * fix: lint formatter * feat: refactor format full year * feat: config github actions on v3 * feat: refactor security code length validation * feat: add jcb card * feat: add coverage to actions * feat: update dependencies * chore: update version * chore: add release-it config * fix: add right token * fix: change token name * feat: change event trigger * feat: add tokenref * feat: add conventional changelog * chore: return version * chore: update version * feat: upgrade to a more functional approach BREAKING CHANGE: this version does not require an instance in order to work. Please, check the diff. * feat: add minified package Co-authored-by: Luiz Fernando Rodrigues <fernahh@gmail.com> Co-authored-by: Edmo Lima <devedmo@gmail.com> Co-authored-by: Carlos Roberto Gomes Junior <carlos.rberto@gmail.com> Co-authored-by: Jhon Mike <developer@jhonmike.com.br> Co-authored-by: Lucas F. Bittencurt <lucasfilipeb@gmail.com> Co-authored-by: Ciro Ferreira da Cruz <ciro.cfc@gmail.com> Co-authored-by: Ciro Ferreira da Cruz <ciro.cruz@contaazul.com> Co-authored-by: Guilherme Tavares <zetavares.rib@gmail.com> Co-authored-by: Mateus Craveiro <mccraveiro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today there is a folder
distthat should be commited. But, thenpm prepublishwill generatedistfolder to upload on npm:creditcard.js/package.json
Line 21 in a0712b3
distfolder to npm files.gitignoreand.npmignore.closes #62