Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLPayload does not return proper response to allow proper handling #446

Closed
symcssn opened this issue Sep 8, 2015 · 1 comment
Closed
Milestone

Comments

@symcssn
Copy link
Contributor

symcssn commented Sep 8, 2015

Currently, if getting an object is not successful, the user does not
know whether the GET was successful or not. For example, if the result
is a 404, then reading from the InputStream will result in the stream
containing the message saying data not available instead of the data
that is actually wanted.

Steps to reproduce:
Try to download a file that does not exist. Reading the input stream

Proposed solution:
Allow users to check the response to see whether the request is
successful or not before reading form the input stream.

gondor added a commit that referenced this issue Sep 10, 2015
Fix OSAuthenticator. authenticateV3 (Fixes #444, #446)
@symcssn
Copy link
Contributor Author

symcssn commented Sep 22, 2015

hi @gondor

I'm closing this since the issue has been fixed and merged.

@symcssn symcssn closed this as completed Sep 22, 2015
@gondor gondor modified the milestone: 2.0.6 Release Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants