[issue 1094] Fix NPEs caused by okhttp HttpExecutorServiceImpl #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connectors.okhttp.HttpExecutorServiceImpl.execute no longer returns null. If it encounters an exception, it now throws.
|
That was open for quite some time. Apologies. Thanks for fixing this @pjdarton. Can we close the corresponding issue? |
|
Yes; close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.openstack4j.connectors.okhttp.HttpExecutorServiceImpl.execute(...) no longer returns null.
If it encounters an exception, it now throws.
Previously it suppressed the original exception and returned null, causing downstream code to fail with a NullPointerException.
See #1094 for details.