-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing error when Glance V2 image contains optional locations #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@baseman79 thanks for the fix, can you please add a test case for this? |
@vinodborole sure thing, will add one shortly, thx |
Thanks @baseman79 |
posox
added a commit
to posox/clouddriver
that referenced
this pull request
Aug 27, 2018
It's a workaround for issue in Openstack4j library, locations cannot be used without fix ContainX/openstack4j#1096 Spinnaker issue: spinnaker/spinnaker#3018
posox
added a commit
to posox/clouddriver
that referenced
this pull request
Aug 27, 2018
It's a workaround for issue in Openstack4j library, locations cannot be used without fix ContainX/openstack4j#1096 Spinnaker issue: spinnaker/spinnaker#3018
posox
added a commit
to posox/clouddriver
that referenced
this pull request
Aug 31, 2018
It's a workaround for issue in Openstack4j library, locations cannot be used without fix ContainX/openstack4j#1096 Spinnaker issue: spinnaker/spinnaker#3018
tomaslin
pushed a commit
to spinnaker/clouddriver
that referenced
this pull request
Aug 31, 2018
…2912) It's a workaround for issue in Openstack4j library, locations cannot be used without fix ContainX/openstack4j#1096 Spinnaker issue: spinnaker/spinnaker#3018
clanesf
pushed a commit
to clanesf/clouddriver
that referenced
this pull request
Dec 8, 2018
…pinnaker#2912) It's a workaround for issue in Openstack4j library, locations cannot be used without fix ContainX/openstack4j#1096 Spinnaker issue: spinnaker/spinnaker#3018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing parsing error when image from Glance V2 contains "locations"
According to Glance API V2:
Add a new Location object, and replace the locations from List to List