domain scoped authentication with tests #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mazimo, |
|
|
||
| return new V2Token(id, token.getExpires(), token.getVersion(), tenant); | ||
| } | ||
| else if(token.getDomain() != null) { |
There was a problem hiding this comment.
Probably could break this out of a nested else sequence. ie. if (token.get...) since the previous condition is returning a token
There was a problem hiding this comment.
Right. But if you don't mind I would leave it that way for now and do better on the new dedicated v3 branch :)
|
Looks good @auhlig from an implementation standpoint. LGTM |
|
👍 LGTM |
gondor
added a commit
that referenced
this pull request
Nov 15, 2015
domain scoped authentication with tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR related to issue Domain scoped authentication #497 and enables OpenStack4j to authenticate with a domain scope in the identity v3 case.
This is the last commit for this kind of issues which is compatible to the v2 implementation.