-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Senlin module #680
Add Senlin module #680
Conversation
* returns details of a {@link Node}. | ||
* | ||
* @param nodeID | ||
* Id of {@link Node} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update for Node?
http://developer.openstack.org/api-ref-clustering-v1.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update function need to be sent request as PATCH method. But the SDK do not support this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@L-I-O-N: Actually it does. We're using HTTP PATCH in the Identity V3 part.
@L-I-O-N Thanks a lot for this effort, appreciate it. Please have a look at the review comments and please add test cases for your implementation |
I agree with everything @vinodborole has said @L-I-O-N . Thank you for the contribution. Could you also create an Issue for this PR and associate it in the description or comments. Thank you again |
I have modified all of the review comments and re submitted the code.Please review. |
@vinodborole @gondor @auhlig Thanks a lot. |
Thanks for the contribution @L-I-O-N - merging now |
I'm reverting this merge. Too many build errors including "case" of file names with senlin/version.java. Please test using a clean "mvn verify" |
Thanks for your trust and I'm sorry for my mistake.I hava fix it,and create a new PR. @gondor |
As openstack mitaka version add a new core project which is called Senlin. According to the basic framework, I Add a new module to implements Senlin RESRful API.And I hava tested all the basic functions of this module. #684