Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Senlin module #680

Merged
merged 6 commits into from
Jun 8, 2016
Merged

Add Senlin module #680

merged 6 commits into from
Jun 8, 2016

Conversation

L-I-O-N
Copy link
Contributor

@L-I-O-N L-I-O-N commented May 23, 2016

As openstack mitaka version add a new core project which is called Senlin. According to the basic framework, I Add a new module to implements Senlin RESRful API.And I hava tested all the basic functions of this module. #684

* returns details of a {@link Node}.
*
* @param nodeID
* Id of {@link Node}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update function need to be sent request as PATCH method. But the SDK do not support this method.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@L-I-O-N: Actually it does. We're using HTTP PATCH in the Identity V3 part.

@vinodborole
Copy link
Contributor

@L-I-O-N Thanks a lot for this effort, appreciate it. Please have a look at the review comments and please add test cases for your implementation

@gondor
Copy link
Member

gondor commented May 24, 2016

I agree with everything @vinodborole has said @L-I-O-N . Thank you for the contribution. Could you also create an Issue for this PR and associate it in the description or comments. Thank you again

@L-I-O-N
Copy link
Contributor Author

L-I-O-N commented May 31, 2016

I have modified all of the review comments and re submitted the code.Please review.

@L-I-O-N
Copy link
Contributor Author

L-I-O-N commented May 31, 2016

@vinodborole @gondor @auhlig Thanks a lot.

@gondor
Copy link
Member

gondor commented Jun 8, 2016

Thanks for the contribution @L-I-O-N - merging now

@gondor gondor closed this Jun 8, 2016
@gondor gondor reopened this Jun 8, 2016
@gondor gondor merged commit 0f442ce into ContainX:master Jun 8, 2016
@gondor
Copy link
Member

gondor commented Jun 8, 2016

I'm reverting this merge. Too many build errors including "case" of file names with senlin/version.java. Please test using a clean "mvn verify"

@gondor gondor mentioned this pull request Jun 8, 2016
@L-I-O-N
Copy link
Contributor Author

L-I-O-N commented Jun 8, 2016

Thanks for your trust and I'm sorry for my mistake.I hava fix it,and create a new PR. @gondor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants