-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing api for cinder #791
Conversation
This change was originally committed by Elina Meier (elina.meier@ericsson.com). The commit was modified and adapted to openstack4j 3.x by Qin An
Thanks @biogerm for the contribution, looks good. It would be good if you can add few units test around this? |
@vinodborole I actually removed the tests which are wrote based on openstack4j 1.x |
Any reason for changing the import pattern in the Builders? |
@auhlig Thanks for pointing out. I guess it was because of the merge between really old code. And I realized that the other comment I was suppose to sent was not sent... Here it goes... |
Hi Community, We work in Ericsson and has been using and improving Openstack4j for 2 years. Only until recently did we get the permit to contribute our changes back to Github, and we are so happy about it. I am currently working on modifying and upstreaming these changes here. These changes are in general working fine with us for a long time. I will group them in several pull requests that I hope they won't dependent on each other. BR |
@biogerm we would really like to have those changes; please do send those PR and we can look at it. Thanks again for your contribution! |
@biogerm Awesome! looking forward to the contributions |
@vinodborole Test is now included. Just wondering if I should send it as another pull request or it's fine to have two commits? |
things are breaking.. i'm on it.. |
LGTM |
@vinodborole awaiting your final review. Merge if it looks good |
apologies for the delay, LGTM |
This change was originally committed by Elina Meier (elina.meier@ericsson.com).
The commit was modified and adapted to openstack4j 3.x by Qin An
In this commit, VolumeType was supported.