Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing attributes in Keypair issue:#860 #861

Merged
merged 4 commits into from
Oct 24, 2016
Merged

Conversation

whaon
Copy link
Contributor

@whaon whaon commented Oct 21, 2016

add missing attributes in Keypair issue: #860

@auhlig auhlig added this to the 3.0.3 Release milestone Oct 21, 2016
*
* @return id of the keypair
*/
Integer getId();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider the below response content that I get from the url you given

{
    "keypair": {
        "fingerprint": "44:fe:29:6e:23:14:b9:53:5b:65:82:58:1c:fe:5a:c3",
        "name": "keypair-6638abdb-c4e8-407c-ba88-c8dd7cc3c4f1",
        "public_key": "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC1HTrHCbb9NawNLSV8N6tSa8i637+EC2dA+lsdHHfQlT54t+N0nHhJPlKWDLhc579j87vp6RDFriFJ/smsTnDnf64O12z0kBaJpJPH2zXrBkZFK6q2rmxydURzX/z0yLSCP77SFJ0fdXWH2hMsAusflGyryHGX20n+mZK6mDrxVzGxEz228dwQ5G7Az5OoZDWygH2pqPvKjkifRw0jwUKf3BbkP0QvANACOk26cv16mNFpFJfI1N3OC5lUsZQtKGR01ptJoWijYKccqhkAKuo902tg/qup58J5kflNm7I61sy1mJon6SGqNUSfoQagqtBH6vd/tU1jnlwZ03uUroAL Generated-by-Nova\n",
        "user_id": "fake",
        "deleted": false,
        "created_at": "2014-05-07T12:06:13.681238",
        "updated_at": null,
        "deleted_at": null,
        "id": 1
    }
}

I think the id means the identity of the keypair

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm blind

@whaon
Copy link
Contributor Author

whaon commented Oct 21, 2016

I just merge the code that resolve the issue: #859
I try my best to make it correct but it may still have problems.Our Openstack environment is lower than 2.26 while the api is available since version 2.26(please refer the api document),so I can't make a test for my code.
Please test my code and if it has any problems,just contact me for free,Thanks!

@auhlig
Copy link
Member

auhlig commented Oct 21, 2016

I'd rather like to ask you to extend or add some unit tests. See https://github.com/ContainX/openstack4j/tree/master/core-test/src/main/java/org/openstack4j/api/compute

@auhlig
Copy link
Member

auhlig commented Oct 24, 2016

Cool. Many thanks for the work @whaon, @tongh-qtl. Looks good from my side. Do you agree @vinodborole ?

@vinodborole
Copy link
Contributor

LGTM

@auhlig auhlig merged commit 85a8af3 into ContainX:master Oct 24, 2016
@auhlig
Copy link
Member

auhlig commented Oct 24, 2016

@whaon @tongh-qtl Could you create a PR for https://github.com/ContainX/openstack4j.com and add documentation for the newly introduced methods? Many thanks in advance.

@whaon
Copy link
Contributor Author

whaon commented Oct 24, 2016

it's ok,but maybe I will do it a bit later
and could you give some tools to do this?Or I just modify the html file or markdown file?

whaon added a commit to whaon/openstack4j that referenced this pull request Oct 25, 2016
Merge pull request ContainX#861 from whaon/master
@auhlig
Copy link
Member

auhlig commented Oct 26, 2016

Hey @whaon,
Right. It's just markdown and a little amount of html if you want to set some links. Would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants