Hyperlink DOIs against preferred resolver #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 30, 2018
|
PS: Because there can basically be 4 DOI URL variants, the reg-ex in https://github.com/ContentMine/phylotree/blob/efa09c1f0a2e8bd50022788529e66d18276fa25e/input-metadata/scraping/by-year/strip-images-ijsem.sh#L20 might need to be updated. |
tarrow
requested changes
May 30, 2018
|
Hey! Thanks for the PR, that is awesome. I'd be happy to merge but could you unstage the change in the test file? |
|
Sure, done :-) |
|
Thanks! That's awesome. |
tarrow
approved these changes
May 31, 2018
|
You're welcome, and thanks for merging :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :-)
The DOI foundation recommends this new resolver. Yes, a bit ironic, but it's now encrypted and the old links with the
dxsubdomain continue to work.So, there is no urgent need to do anything, but nonetheless, I'd like to suggest to hereby update the code that generates new ones.
Cheers!