Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session_timeout bug fix & Local Build Process fixup #119

Closed
wants to merge 17 commits into from

Conversation

pavelnemirovsky
Copy link
Contributor

@pavelnemirovsky pavelnemirovsky commented May 24, 2021

  • Bump to newer go
  • Dependencies fix

In continue of #117

Copy link
Contributor

@vfoucault vfoucault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it would be better to switch to goreleaser with github actions. It would save the hassle to deal with local file, and would ease the release process for new tags.

Could you also squash your commits. Thx

@pavelnemirovsky
Copy link
Contributor Author

@vfoucault yes, that's exactly what I proposed in my original PR since there is no automatic versioning and artifact building. Let's do it, Let's squash once it will be merged into master.

@pavelnemirovsky pavelnemirovsky changed the title Tiny adjustement for makefile Session_timeout bug fix & Local Build Process fixup Jun 3, 2021
@gontarzpawel
Copy link
Contributor

Hello @pavelnemirovsky , github actions are now available in chproxy. Could you rebase your PR so we can leverage the fix you'd submitted for session timeout?

@mga-chka
Copy link
Collaborator

I'm closing this PR since it has been stale for too long. Feel free to re open it if you want to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants