Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from github.com/DataDog/zstd to github.com/klauspost/compress/zstd #238

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

jb-abbadie
Copy link
Contributor

Description

This allow us to have a pure Go package which is much easier to package
on different OS/Architectures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • [] Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

I will do a PR to put CGO_ENABLED=0 in all of the CI once this PR is merged

Copy link
Collaborator

@LEijsackersCS LEijsackersCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I have two comments.

chdecompressor/decompressor.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
This allow us to have a pure Go package which is much easier to package
on different OS/Architectures
Copy link
Collaborator

@LEijsackersCS LEijsackersCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mga-chka mga-chka merged commit f8f3e83 into ContentSquare:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants