Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cf #256, having the same cache for all users could be a security leak with wildcarded user (and is a smaller leak without wildcarded user).
The aim is to have a cache per user by default and let the admin choses whether or not the cache should be shared btw all users
Pull request type
Please check the type of change your PR introduces:
Checklist
Does this introduce a breaking change?
after the upgrade, all the queries put in cache (redis or filesystem) put by a previous version of chproxy will not be seen by the new version. Moreover, by default the queries won't be shared per user unless explicitly asked in the conf.
Further comments