Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache per user #258

Merged
merged 2 commits into from
Nov 9, 2022
Merged

cache per user #258

merged 2 commits into from
Nov 9, 2022

Conversation

mga-chka
Copy link
Collaborator

@mga-chka mga-chka commented Nov 2, 2022

Description

cf #256, having the same cache for all users could be a security leak with wildcarded user (and is a smaller leak without wildcarded user).
The aim is to have a cache per user by default and let the admin choses whether or not the cache should be shared btw all users

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No
    after the upgrade, all the queries put in cache (redis or filesystem) put by a previous version of chproxy will not be seen by the new version. Moreover, by default the queries won't be shared per user unless explicitly asked in the conf.

Further comments

@render
Copy link

render bot commented Nov 2, 2022

@mga-chka mga-chka removed the wip label Nov 6, 2022
Copy link
Contributor

@sigua-cs sigua-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mga-chka mga-chka merged commit 1152cd2 into master Nov 9, 2022
@mga-chka mga-chka deleted the dedicated_cache_per_user branch November 9, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants