Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: build local docker image #302

Merged
merged 2 commits into from
Feb 22, 2023
Merged

doc: build local docker image #302

merged 2 commits into from
Feb 22, 2023

Conversation

sigua-cs
Copy link
Contributor

  • remove dockerignore
  • doc: build local docker image

Description

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

@render
Copy link

render bot commented Feb 20, 2023

Your Render PR Server URL is https://chproxy-pr-302.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cfphiphmbjssa2u89du0.

@sigua-cs sigua-cs marked this pull request as ready for review February 20, 2023 06:56
Blokje5
Blokje5 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@Blokje5 Blokje5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sigua-cs sigua-cs merged commit cdea70f into master Feb 22, 2023
@sigua-cs sigua-cs deleted the chore/installation-doc branch February 22, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blokje5 Blokje5 Blokje5 approved these changes

@gontarzpawel gontarzpawel Awaiting requested review from gontarzpawel

@mga-chka mga-chka Awaiting requested review from mga-chka

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigua-cs @Blokje5