Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Generics for new benchmark components #1011

Merged

Conversation

NickLucche
Copy link
Member

Proposal/first draft addressing the type hint issue which we currently have with CLStream and custom CLExperience (language server can't see their properties and methods).
An example of this is the RLScenario which now properly displays the return type of its train/eval streams (RLExperience).

I've also added task labels for eval experiences when creating an RLScenario.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2271465330

  • 8 of 35 (22.86%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 70.599%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/benchmarks/scenarios/test_rl_scenario.py 0 9 0.0%
avalanche/benchmarks/scenarios/rl_scenario.py 2 20 10.0%
Files with Coverage Reduction New Missed Lines %
avalanche/benchmarks/scenarios/rl_scenario.py 1 28.36%
tests/benchmarks/scenarios/test_rl_scenario.py 1 18.18%
Totals Coverage Status
Change from base Build 2263070818: -0.05%
Covered Lines: 12011
Relevant Lines: 17013

💛 - Coveralls

@AntonioCarta
Copy link
Collaborator

Great!

@AntonioCarta AntonioCarta merged commit 623bf10 into ContinualAI:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants