Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD new test #908

Merged
merged 6 commits into from
Feb 8, 2022
Merged

Conversation

AntonioCarta
Copy link
Collaborator

add a bunch of tests needed to ensure the new strategies are not breaking anything. Should fix the tests breaking in #905

@ContinualAI-bot
Copy link
Collaborator

Oh no! It seems there are some PEP8 errors! 😕
Don't worry, you can fix them! 💪
Here's a report about the errors and where you can find them:

tests/training/test_supervised_regression.py:53:25: E251 unexpected spaces around keyword / parameter equals
tests/training/test_supervised_regression.py:53:27: E251 unexpected spaces around keyword / parameter equals
2       E251 unexpected spaces around keyword / parameter equals

@coveralls
Copy link

coveralls commented Feb 8, 2022

Pull Request Test Coverage Report for Build 1811463576

  • 307 of 377 (81.43%) changed or added relevant lines in 8 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 77.866%

Changes Missing Coverage Covered Lines Changed/Added Lines %
avalanche/benchmarks/utils/data_loader.py 14 24 58.33%
tests/training/test_supervised_regression.py 225 285 78.95%
Files with Coverage Reduction New Missed Lines %
avalanche/models/dynamic_modules.py 1 95.37%
avalanche/benchmarks/utils/data_loader.py 2 87.97%
Totals Coverage Status
Change from base Build 1796153147: 0.5%
Covered Lines: 11620
Relevant Lines: 14923

💛 - Coveralls

@AntonioCarta AntonioCarta merged commit 5d5d311 into ContinualAI:master Feb 8, 2022
@AntonioCarta AntonioCarta deleted the new_base_strategy branch February 8, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants