Adding CLEAR-10 benchmark to Avalanche #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2077989484
💛 - Coveralls |
lrzpellegrini
requested changes
Apr 1, 2022
| raise NotImplementedError() | ||
|
|
||
| if feature_type is None: | ||
| assert isinstance(train_transform, type(None)), "No image transform" |
There was a problem hiding this comment.
I haven't tried to run the code, but from the main below it seems that non-None transformations should be allowed when feature_type is None...
There was a problem hiding this comment.
You are right, I should remove the assertion statement (it was a typo). My original purpose is to make sure the user specify a transformation for image, and not inputting a transformation for feature tensors. But on a second thought, I should leave this choice to users!
|
Made the change by removing assertion statements. |
|
@lrzpellegrini if you are satisfied we can merge the PR. |
lrzpellegrini
approved these changes
Apr 4, 2022
|
Thanks again @linzhiqiu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#964 PR for this feature request