added backwards compatability for pandas term parsing so we can work wit... #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you guys are really cogniscent of these little details! (and to think the original arbitrary format is still in existence! - when it was a 1-hour hack to create it!) |
|
@jreback, it's just cause we have library code that uses the old syntax, also we construct queries programatically sometimes, so in that case dealing with lists of tuples is easier than doing our own string parsing. |
…ate caching bugs as well. Rewrote config.py for YAML format. @hhuuggoo can you confirm that start=start_row, stop=end_row are unnecessary inf store_select statements now?
|
@hhuuggoo can you review my changes and merge? |
…quasiben's changes which were necessary due to the bugs - coerce start/stop to ints, sometimes we were passing series of length 1 int there - quoting strings for pandas expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@quasiben @spearsem
pandas 0.13 breaks old style pytables query syntax, I ripped out one of their backwards compat functions so we could use it
few changes
The reason this is necessary, is that pandas fixed their backwards compatibility logic with the old query syntax in 0.14, but 0.13 is out and is broken, pandas-dev/pandas#6313