NODE 1428: Adapt express and koa to use HTTP/2 #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcolekaplan
commented
Apr 22, 2021
meandthemoon
requested changes
Apr 23, 2021
express/index.js
Outdated
| if (isHttps) { | ||
| server = https.createServer(options, app); | ||
| } else if (isHttp2) { | ||
| server = http2.createServer(options, app); |
There was a problem hiding this comment.
Don't we want http2.createSecureServer(options, app) here?
There was a problem hiding this comment.
It doesn't look like spdy has a createSecureServer method: https://github.com/spdy-http2/node-spdy
…ng certificate when using HTTP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some confusion because the ticket specifies:
but according to some of the documentation included in that same ticket: https://www.perimeterx.com/tech-blog/2019/http2/
So I'm assuming it was a typo and that Koa should be adapted to use the native HTTP/2 library and Express should use Spdy. It doesn't look like Express will be compatible with the native library any time soon: expressjs/express#3388