-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing the download links to point to Phoebus #13
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
✅ Deploy Preview for inquisitive-malabi-c369c9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea how this works and why "peaceful jackson" isn't happy, but certainly a good idea to remove broken links.
Instead of adding links to specific versions like ../relases/download/v4.7.2, it should also be OK to just have the ".../releases" link, so users can then pick whatever is the latest, and you don't need to update this with every release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Netlify works by linking to github repos and the peaceful-jackson and a few of the other netlify sites are old and probably owned by Will Rogers or others. We migrated control of netlify to Kunal's site but that required using a newer version of node JS which then broke the old Netlify sites. And we can't figure out a way to get them disconnected from the github repo.
Anyways as long as inquisitive-malabi works we are good :)
Changes look good. There was a tech talk asking about downloading CS-Studio Eclipse for building .opi files from this site, should we also include a link to download the Eclipse version from github? If we have one?
we should build the common eclipse CS-Studio products, host them on github and then add the link for sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @kasemir, link to releases should be sufficient. Maybe som text explaining that the target will always list the latest version.
removing the references to the now non functional downloads.controlsystemstudio.org ( it would still be good to know who was hosting that )
This is just the first step while we figure out how to automatically publish on github and find a solution for the nightly common builds