Resize the legend area when traces are hidden #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build fails due to an unrelated issue - see fix in PR #2726. PR 2726 needs to be merged and pulled into this branch first before re-running the CI job for this PR. |
kasemir
pushed a commit
to ControlSystemStudio/phoebus
that referenced
this pull request
Feb 27, 2024
Port of update from SWT implementation ControlSystemStudio/cs-studio#2725
|
Turns out the JFX version had the 'continue' part but still counted all traces, so thanks for this update |
|
@rjwills28 can you update this branch... with #2726 merged we should be able to get the CI working again here |
The legend area is determined using the legends of all the traces even if they are not being displayed. This fix addresses that by only considering the visible traces.
rjwills28
force-pushed
the
css610_legend_area
branch
from
351b9f1
to
2346488
Compare
shroffk
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We came across an issue in the databrowser where the area taken up to display the traces legend does not shrink when traces are hidden. This is particular noticeable if the plot contains many traces of which most are hidden.
It turns out that in the code the legend area is determined using all the traces even if they are not being displayed. This PR fixes this issue by only considering the visible traces.