In-memory preferences #3041
Merged
In-memory preferences #3041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3040
Removes the
FileSystemPreferencesthat we copied from the Linux preference implementation withInMemoryPreferences.Preferences are thus initialized from our
...preferences.propertiesfiles, updated with optionalsettings.inibundled in the product's "install" location, and finally updated via-settings /path/to/xx.inicommand line options either in a launcher script or directly via the command line.Preferences are no longer persisted, removing the surprises seen in the past when running a product with some
-settings ...and then still seeing the effect when later NOT running with those-settings .., which is especially confusing whenalarm-server -settings ..is followed byphoebusand the latter then sees settings from the former.Also means we no longer need to worry about deprecated API in the
FileSystemPreferences.Updated related documentation.