CSSTUDIO-3523 Bugfix: Use layoutBoundsWithoutScrollbars instead of layoutBoundsWithScrollbars in if-condition

[abrahamwolk]

This pull request fixes a bug introduced in #3489: when determining whether the width and height specified in outline or in model should be used for computing the zoom-level when zooming, layoutBoundsWithoutScrollbars should be compared against instead of layoutBoundsWithoutScrollbars. I have tested this change manually in the Display Builder.

[jacomago]

Would be nice if commit explained "why" the change rather than just the "what".

[abrahamwolk]

Would be nice if commit explained "why" the change rather than just the "what".

I don't have a full understanding of the underlying cause, but this pull request is intended to restore the logic described here:

phoebus/app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/JFXRepresentation.java

Lines 508 to 516 in 4d9b2e4

	// 'outline' will wrap the actual widgets when the display
	// is larger than the available viewport.
	// So it can be used to zoom 'out'.
	// But when the viewport is much larger than the widget,
	// the JavaFX outline grows to fill the viewport,
	// so falling back to the self-declared model width and height
	// to zoom 'in'.
	// This requires displays to be created with
	// correct width/height properties.

In #3489, I had changed the logic (as part of a larger change), so that it was not the case that the full viewport was considered in the comparison.

Empirically, it also seems that the fix works.