Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for version 2.021 #257

Closed
binaryguru opened this issue Sep 28, 2019 · 22 comments
Closed

Support for version 2.021 #257

binaryguru opened this issue Sep 28, 2019 · 22 comments
Assignees
Labels

Comments

@binaryguru
Copy link

Loading the script locks the game up.

@psiie
Copy link

psiie commented Sep 28, 2019

I have a merge request in place that fixes the crashes. Does not support new features, but makes it so it works with the game again.

Until the merge request is fixed, you can load it from here: https://raw.githubusercontent.com/darkenvy/CookieMonster/2.021-hotfix/CookieMonster.js

You wont be able to use Game.load() however as it throws a CORS issue. This is why Aktanusa hosts the script on their own website. So you will have to copy and paste the entire script into your console window bleh!

Or just make a tampermonkey script. The below does work. I tested it. Just be sure to paste the script where I left the note.

// ==UserScript==
// @name Cookie Monster
// @namespace Cookie
// @include http://orteil.dashnet.org/cookieclicker/
// @include https://orteil.dashnet.org/cookieclicker/
// @version 1
// @grant none
// @description Loads the CookieMonster helper tool for CookieClicker Idle game
// ==/UserScript==

(function() {
    var checkReady = setInterval(function() {
        if (typeof Game.ready !== 'undefined' && Game.ready) {
            loadCMManually();
            clearInterval(checkReady);
        }
    }, 1000);
}());

function loadCMManually() {
 // ###### paste the contents of https://raw.githubusercontent.com/darkenvy/CookieMonster/2.021-hotfix/CookieMonster.js here #######
}

UPDATE: You can use Game.LoadMod('https://cdn.statically.io/gh/darkenvy/CookieMonster/2.021-hotfix/CookieMonster.js'); as @storgall pointed out :). Thanks Storgall!

@Aktanusa
Copy link
Collaborator

Yep, working on it... Thanks @darkenvy, as I said in your pull request, I'll take a look at your changes and will give you credit.

@Aktanusa Aktanusa self-assigned this Sep 29, 2019
@Aktanusa Aktanusa added the Bug label Sep 29, 2019
@normann1974
Copy link

What's the plan for fortune cookies? It would be nice with a sound being played.

@Piruparka
Copy link

Piruparka commented Oct 1, 2019

I have a merge request in place that fixes the crashes. Does not support new features, but makes it so it works with the game again.

Until the merge request is fixed, you can load it from here: https://raw.githubusercontent.com/darkenvy/CookieMonster/2.021-hotfix/CookieMonster.js

You wont be able to use Game.load() however as it throws a CORS issue. This is why Aktanusa hosts the script on their own website. So you will have to copy and paste the entire script into your console window bleh!

Or just make a tampermonkey script. The below does work. I tested it. Just be sure to paste the script where I left the note.

// ==UserScript==
// @name Cookie Monster
// @namespace Cookie
// @include http://orteil.dashnet.org/cookieclicker/
// @include https://orteil.dashnet.org/cookieclicker/
// @version 1
// @grant none
// @description Loads the CookieMonster helper tool for CookieClicker Idle game
// ==/UserScript==

(function() {
    var checkReady = setInterval(function() {
        if (typeof Game.ready !== 'undefined' && Game.ready) {
            loadCMManually();
            clearInterval(checkReady);
        }
    }, 1000);
}());

function loadCMManually() {
 // ###### paste the contents of https://raw.githubusercontent.com/darkenvy/CookieMonster/2.021-hotfix/CookieMonster.js here #######
}

UPDATE: You can use Game.LoadMod('https://cdn.statically.io/gh/darkenvy/CookieMonster/2.021-hotfix/CookieMonster.js'); as @storgall pointed out :). Thanks Storgall!

Weird question but how do I do this using Chrome?

@normann1974
Copy link

It doesn't seem to work in any useful way. All bonus incomes and payback periods are negative.

@Piruparka
Copy link

I made it work now and it's ok.

I created a bookmark aiming at

javascript:(function() { Game.LoadMod('https://cdn.statically.io/gh/darkenvy/CookieMonster/2.021-hotfix/CookieMonster.js'); }());

and clicked then while the game is running

@Batman42
Copy link

Batman42 commented Oct 1, 2019

I've tried all the bookmarks above. None seem to work in the way they are supposed to. Payback periods are all negative and aren't calculating properly.

@Piruparka
Copy link

Try the one I pasted above, I'm running it rn and it's running ok

@Fataky
Copy link

Fataky commented Oct 1, 2019

Try the one I pasted above, I'm running it rn and it's running ok

It works perfectly for me. Thanks!

@Aktanusa
Copy link
Collaborator

Aktanusa commented Oct 1, 2019

Thanks @Piruparka for helping out while waiting for me. I understand a lot of people are waiting on me, and I'm trying to get on it ASAP.

@normann1974 Yes, it has been requested already. I'll try to add it also if it's not too complicated, or else it will be added later.

@Batman42
Copy link

Batman42 commented Oct 1, 2019

Try the one I pasted above, I'm running it rn and it's running ok

I've tried that one, I think it was working until I bought the new executive kitten upgrade then it went back to not working

@Azmaeus
Copy link
Contributor

Azmaeus commented Oct 2, 2019

The negative numbers are apparently a result of the new Dragon Aura, per #256 - however I switched to a different aura and am still experiencing this...?

@Azmaeus
Copy link
Contributor

Azmaeus commented Oct 2, 2019

@normann1974 Yes, it has been requested already. I'll try to add it also if it's not too complicated, or else it will be added later.

@Aktanusa I can't find the request, was hoping to make comments. If it's public I'd appreciate a link, otherwise I'm working on a PR, hopefully I'll have something soon.

@Aktanusa
Copy link
Collaborator

Aktanusa commented Oct 2, 2019

@Azmaeus It was an informal request on reddit. I guess I should make an issue, or get someone to do it, lol. Tomorrow, I'll make an issue if no one does.

@mocnik
Copy link

mocnik commented Oct 2, 2019

I have fixed some issues with payback period calculation (add new kitten and fortune upgrades, fix building fortune bonuses) in https://github.com/mocnik/CookieMonster/tree/2.021-hotfix, feel free to use it.

@Aktanusa
Copy link
Collaborator

Aktanusa commented Oct 2, 2019

@mocnik Thanks, it will help me. I have started to look at the changes last night, and so far, it doesn't look to bad. I will have more progress tonight.

@moguling
Copy link

moguling commented Oct 2, 2019

@mocnik Is there a way to use this version in a bookmarklet?

@Doogie2K
Copy link

Doogie2K commented Oct 2, 2019

Thanks for doing this @Aktanusa, and thanks for the hotfix, @darkenvy. I appreciate the work that goes into this mod, and that y'all have lives that don't necessarily revolve around a silly browser game. ;)

@Zatch97
Copy link

Zatch97 commented Oct 3, 2019

Hi guys, thanks for your great work, just wondering if it's normal with the hotfixes that I don't have access to the Cookie Monster panel that was replacing the Info panel?

@Antwelm
Copy link

Antwelm commented Oct 3, 2019

Hi guys, thanks for your great work, just wondering if it's normal with the hotfixes that I don't have access to the Cookie Monster panel that was replacing the Info panel?

Stats & Options show Monster tweaks here, info-tab shows normal CC info.

@shiioo
Copy link

shiioo commented Oct 3, 2019

@moguling yes, just follow previous recommendations on this same thread:

javascript: (function () { Game.LoadMod('https://cdn.statically.io/gh/mocnik/CookieMonster/2.021-hotfix/CookieMonster.js'); }());

@Aktanusa
Copy link
Collaborator

Aktanusa commented Oct 7, 2019

Fixed in Version 2.021.1

@Aktanusa Aktanusa closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests