Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Buildings display method CM.Disp.UpdateBuildings throws an error in sell mode #364

Closed
Chorizorro opened this issue Nov 29, 2020 · 1 comment · Fixed by #365
Closed

Comments

@Chorizorro
Copy link
Contributor

⚠️ This bug concerns the dev branch, not the actual 2.031.1 release ⚠️

When switching to "Sell" mode for buildings, the JS console starts throwing this error at each Game loop execution:

Uncaught TypeError: can't convert undefined to object
    UpdateBuildings http://localhost/cookiemonster/CookieMonster.js:1401
    Loop http://localhost/cookiemonster/CookieMonster.js:3336
    Loop http://localhost/cookiemonster/CookieMonster.js:3246
    setTimeout handler*Game.Launch/Game.Loop https://orteil.dashnet.org/cookieclicker/main.js?v=2.089:14457
    Loop http://localhost/cookiemonster/CookieMonster.js:3245
    setTimeout handler*Game.Launch/Game.Loop https://orteil.dashnet.org/cookieclicker/main.js?v=2.089:14457
    Loop http://localhost/cookiemonster/CookieMonster.js:3245
    // [...] Lines after this are irrelevant, it's a repeat of Loop / setTimeout
CookieMonster.js:1401:19

This has been most likely introduced in d40f90d from #340
I could reproduce it in both "Sort Buildings: Default" and "Sort Buildings: PP" mode.

DanielNoord added a commit that referenced this issue Nov 29, 2020
Fixed pp-sort breaking for sell-mode (#364)
@DanielNoord
Copy link
Collaborator

Fixed!
Also stopped sell mode column sorting by PP. This will now always sort by id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants