Sort buildings and upgrades by PP #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I feel really bad for taking so long =( |
|
I like this! Any idea when it might get merged? |
|
No idea really, just be patient with me, sorry =( |
|
Will this be merged soon? It has been several months now :) |
|
@DanielNoord I reviewed the code and it looks good, should I go ahead and merge it? |
DanielNoord
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to sort buildings and upgrades based on PP.
The buildings part has been taken from #219, but with changes to solve the conflicts.
Also note issue #151, which is about the sorting of buildings.