Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake with vendor libs #11

Merged
merged 3 commits into from
Jul 24, 2023
Merged

CMake with vendor libs #11

merged 3 commits into from
Jul 24, 2023

Conversation

cann3v
Copy link
Member

@cann3v cann3v commented Jul 22, 2023

PR contains few CMakeLists.txt changes:

  • Now cmake requires the Boost 1.74 or newer;
  • Also cmake automatically downloads and links nlohmann_json with our project.

@cann3v cann3v requested review from c71n93 and temikfart July 22, 2023 11:13
@cann3v cann3v self-assigned this Jul 22, 2023
@cann3v cann3v removed the request for review from c71n93 July 22, 2023 11:40
@cann3v
Copy link
Member Author

cann3v commented Jul 22, 2023

P. S. CI fails due to incorrect image on DockerHub.

@temikfart
Copy link
Member

P. S. CI fails due to incorrect image on DockerHub.

Fixed

@temikfart temikfart changed the title Feature/6 vendor libs CMake with vendor libs Jul 24, 2023
@temikfart temikfart merged commit 1f99d09 into main Jul 24, 2023
@temikfart temikfart deleted the feature/6-vendor-libs branch July 24, 2023 07:10
@temikfart temikfart linked an issue Jul 24, 2023 that may be closed by this pull request
Add vendor libraries #6
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@temikfart temikfart temikfart approved these changes

Assignees

@temikfart temikfart

@cann3v cann3v

Labels
build vendor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add vendor libraries
2 participants
@cann3v @temikfart